Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove integration tests #2153

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Jan 15, 2025

Description

I tried to fix "integration" tests and then decided to completely remove them. "integration" taken in quotes, because it's actually not an integration tests. It is the same test but executed on the compiled output. This doesn't have much sense now and bring more maintenance burden for us.

The unbuild is responsible to validate correctness of entrypoints in the package.json. And the way how we consume packages in tests is as close as possible to real use case with compiled packages, so we are more than on the safe side in this regard.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Jan 16, 2025 11:07am

Copy link

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size
packages/core/dist/index.mjs 2.91 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.37 KB (0%)

@timofei-iatsenko
Copy link
Collaborator Author

Unblocking pipeline from integration tests revealed a problem with typings. I did a fixin this PR, but wondered why it wasn't caught during tsd tests. I dug into tsd setup and found that our setup is obsolete. tsd-lite we use is deprecated and archived. The proposed alternative is https://tstyche.org/

Also with a newer version of tsd / tsd-lite and stricter checks it started complaining about ramda types, so i decided to put an effort to get rid of it.

I will do migration to tstyche in next PRs

@andrii-bodnar andrii-bodnar merged commit 14f19d2 into main Jan 17, 2025
9 checks passed
@andrii-bodnar andrii-bodnar deleted the remove-integration-tests branch January 17, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants