[vcr-2.0] Log corrupt BlobIDs to Azure Table #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2675 +/- ##
============================================
+ Coverage 72.53% 72.61% +0.08%
- Complexity 11552 11574 +22
============================================
Files 810 809 -1
Lines 65687 65755 +68
Branches 8025 8030 +5
============================================
+ Hits 47644 47747 +103
+ Misses 15427 15394 -33
+ Partials 2616 2614 -2 ☔ View full report in Codecov by Sentry. |
snalli
changed the title
snalli
changed the title
| @Override | ||
| protected TableServiceClient buildTableServiceClient(HttpClient httpClient, Configuration configuration, | ||
| RetryOptions retryOptions, AzureCloudConfig azureCloudConfig) { | ||
| return new TableServiceClientBuilder().connectionString(azureCloudConfig.azureTableConnectionString) |
There was a problem hiding this comment.
By default, azureTableConnectionString is null.
Looks like getTableServiceClient will throw exception to the constructor.
Do you test the case when azureTableConnectionString is null?
There was a problem hiding this comment.
Added a method validateTableServiceConfigs which will fail VCR startup if the table-conn-str is null and we are using a conn-str client. The conn-str varies depending on the azure account, so we cannot hardcode it here.
JingQianCloud
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support to record corrupted blobIDs in Azure Table. It extends ReplicaThread to create VcrReplicaThread which overrides logToExternalTable, such that replication between servers is unaffected.