Add a new endpoint to return resource info #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2676 +/- ##
============================================
- Coverage 72.60% 72.43% -0.18%
- Complexity 11567 11572 +5
============================================
Files 809 811 +2
Lines 65755 65882 +127
Branches 8030 8041 +11
============================================
- Hits 47741 47720 -21
- Misses 15389 15543 +154
+ Partials 2625 2619 -6 ☔ View full report in Codecov by Sentry. |
justinlin-linkedin
changed the title
JingQianCloud
approved these changes
Dec 20, 2023
| int numPartitions = getNumberOfPartitionsInResource(resourceName); | ||
| int replicationFactor = 3; // by default it is 3; | ||
| String numReplicaStr = getResourceConfig(resourceName, dcName).getNumReplica(); | ||
| if (numReplicaStr != null) { |
There was a problem hiding this comment.
We may hit exception if the string is not a number.
There was a problem hiding this comment.
then we will get an exception and return 503 back to client
Arun-LinkedIn
approved these changes
Dec 20, 2023
ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixClusterManager.java
Outdated
Show resolved
Hide resolved
ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixClusterManager.java
Outdated
Show resolved
Hide resolved
ambry-clustermap/src/main/java/com/github/ambry/clustermap/HelixClusterManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new endpoint and handler to return some resource information.
Test
Will add unit test