importer: Only use done() callback method #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In node-sass 3.x last "done" parameter is always passed to the custom importer. It should be not necessary to check if done() has been provided. Should-Solve: sass/node-sass#849
|
@saper I think it looks good, I would just also delete readAbstractFileSync and readFirstFileSync since they are not used anymore. |
|
I've merged this to master (rebased). I added more tests around synchronous rendering to be extra sure :) |
|
@eddie-ruva I removed the unused functions as well. |
|
@saper Thank you for the patch. |
|
🏁 |
ghost
mentioned this pull request
chriseppstein
pushed a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node-sass 3.x last "done" parameter is
always passed to the custom importer.
It should be not necessary to check if
done() has been provided.
Should-Solve: sass/node-sass#849