Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in pr limit action #1518

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

majisourav99
Copy link
Contributor

Typo fix in pr limit action

Typo fix in pr limit action.

How was this PR tested?

tested with PR diff.

File: internal/venice-common/src/main/java/com/linkedin/venice/writer/WriterChunkingHelper.java, Lines Changed: 5
File: internal/venice-common/src/main/resources/avro/KafkaMessageEnvelope/v12/KafkaMessageEnvelope.avsc, Lines Changed: 368
The PR has both schema and Java code changes, please make a separate PR for schema changes.
For schema file changes, please update build.gradle to update 'versionOverrides' inside compileAvro task to use fixed protocol version

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@KaiSernLim KaiSernLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is what that was about.

So I was being USED 🤣

@majisourav99 majisourav99 merged commit f0c26c6 into linkedin:main Feb 11, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants