Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Add test timeout for deferred version swap test #1539

Merged
merged 1 commit into from
Feb 19, 2025
Merged

[controller] Add test timeout for deferred version swap test #1539

merged 1 commit into from
Feb 19, 2025

Conversation

misyel
Copy link
Contributor

@misyel misyel commented Feb 15, 2025

Summary, imperative, start upper case, don't end with a period

Adding a test timeout for deferred version swap test

How was this PR tested?

Existing tests

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

sushantmane
sushantmane approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@misyel misyel merged commit 8531b03 into linkedin:main Feb 19, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantmane sushantmane sushantmane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misyel @sushantmane