[admin-tool] Add stores set filter to cluster-batch-task #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new optional parameter STORE_FILTER_FILE to CLUSTER_BATCH_TASK to perform cluster batch task only on the intersection of provided stores and stores in the cluster. This is useful when you have a list of problematic stores that you'd like to perform some repair on, e.g. re-push system store but instead of doing it to all stores in a cluster you can just run CLUSTER_BATCH_TASK with this store list for all clusters and it will only do what's necessary. If needed in the future we can also add other set operations like complement. Which will do some operation on the stores in the cluster excluding stores in the provided filter file.
clients/venice-admin-tool/src/main/java/com/linkedin/venice/AdminTool.java
Outdated
Show resolved
Hide resolved
xunyin8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[admin-tool] Add stores set filter to cluster-batch-task
Add new optional parameter STORE_FILTER_FILE to CLUSTER_BATCH_TASK to perform cluster batch task only on the intersection of provided stores and stores in the cluster. This is useful when you have a list of problematic stores that you'd like to perform some repair on, e.g. re-push system store but instead of doing it to all stores in a cluster you can just run CLUSTER_BATCH_TASK with this store list for all clusters and it will only do what's necessary.
If needed in the future we can also add other set operations like complement. Which will do some operation on the stores in the cluster excluding stores in the provided filter file.
How was this PR tested?
verified in test environment.
Does this PR introduce any user-facing changes?