ZOOKEEPER-4461: Use logback in zookeeper-contrib project #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've only found Ant references in the `-recipes` projects which I don't necesseraly want to migrate, so this patch is focusing on `-contrib` projects. Please review. Author: Andor Molnar <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1807 from anmolnar/ZOOKEEPER-4461
With these commits, the various tests in `TestOperations.cc` set the `last_sent` and `last_recv` fields of the "force-connected" ZooKeeper handle to deterministic values (which match the initial value of the time mock). When that value is not specified, these fields get set to the "real" time at the end of the `forceConnected` function, which can be sufficiently different from the value held in the mock for some of the tests to fail. Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1827 from ztzg/ZOOKEEPER-4479-flaky-c-test-operations
desaikomal
reviewed
Sep 26, 2022
qqu0127
reviewed
Sep 28, 2022
Comment on lines
+537
to
+543
| if (last_recv_send) { | ||
| zh->last_recv = *last_recv_send; | ||
| zh->last_send = *last_recv_send; | ||
| } else { | ||
| gettimeofday(&zh->last_recv,0); | ||
| gettimeofday(&zh->last_send,0); | ||
| } |
There was a problem hiding this comment.
For my own knowledge, what is this change, is this related to logback?
There was a problem hiding this comment.
Nope it's not related to logback but fixing one flaky c test in CI. My bad i should have separated out these changes will keep that in mind from next time :)
abhilash1in
pushed a commit
that referenced
this pull request
Jun 16, 2023
* ZOOKEEPER-4461: Use logback in zookeeper-contrib project * ZOOKEEPER-4479: C tests: Avoid some jitter which results in flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picking second commit for log4j to logback : PR
Cherry picked fix for flaky ctest : PR
Tests
CI and end-to-end tests pipeline
Local zk server testing.
Changes that Break Backward Compatibility (Optional)
NA
Documentation (Optional)
NA