ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')' #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' and ')'
zooinspect logback config file `logback.xml` currently use a pattern of this
`<pattern>%5p [%t] (%F:%L) - %m%n</pattern> `
which not escape the '(' and ')', cause logback to ignore parts after ')'.
according to logback documents, '(' and ')' is used for grouping, need escape by `\` if used as normal char
https://logback.qos.ch/manual/layouts.html#grouping
this pr update it to (add '\' to escape)
`<pattern>%5p [%t] \(%F:%L\) - %m%n</pattern> `
Author: 67 <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>, Andor Molnar <[email protected]>, Mate Szalay-Beko <[email protected]>
Closes apache#1814 from iamgd67/ZOOKEEPER-4465
mgao0
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
LGTM.
Some side notes: I noticed that the mvn test has some failed tests, I think they are unrelated to this change though. Could you change the CI script so that the check fails when there are failed tests? Otherwise, we need to manually check every time and it makes the CI useless.
|
Hey thanks for looking into logs and CI results. So actually way it works is it re-runs few of the flaky tests. So even if you are seeing few failures in logs eventually it did get pass successfully other CI will fail. |
abhilash1in
pushed a commit
that referenced
this pull request
Jun 16, 2023
…' and ')' (#109) Cherry picked #PR1814 Co-authored-by: 67 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picked #PR1814
Tests
The following tests are written for this issue:
CI and end-to-end tests
Local zookeeper testing done.
Changes that Break Backward Compatibility (Optional)
NA
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)