forked from apache/zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing spotbugs errors in Backup/Restore project files. #91
Merged
rahulrane50
merged 4 commits into
linkedin:li-dev/base-3.6.3-znode-group-security
from
rahulrane50:spotbugs_fix_backuprestore_files
Aug 17, 2022
Merged
Fixing spotbugs errors in Backup/Restore project files. #91
rahulrane50
merged 4 commits into
linkedin:li-dev/base-3.6.3-znode-group-security
from
rahulrane50:spotbugs_fix_backuprestore_files
Aug 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrane50
commented
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed review comments.
...r/src/main/java/org/apache/zookeeper/server/backup/storage/impl/FileSystemBackupStorage.java
Show resolved
Hide resolved
mgao0
reviewed
Aug 12, 2022
...eeper-server/src/main/java/org/apache/zookeeper/server/backup/storage/BackupStorageUtil.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/zookeeper/server/backup/storage/impl/FileSystemBackupStorage.java
Show resolved
Hide resolved
abhilash1in
reviewed
Aug 13, 2022
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/BackupStatus.java
Outdated
Show resolved
Hide resolved
mgao0
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn spotbugs has reported few bugs and this PR fixes it from Backup/Restore project files.