Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry point for setting StoreAuthedClientId config property #94

Merged

Conversation

mgao0
Copy link

@mgao0 mgao0 commented Aug 18, 2022

In #87, one entry point for setting the config value is missing. This commit adds the entry point in QuorumPeerConfig.

All znode group acl tests passed.
Will validate the config loading manually by deploying zk server with StoreAuthedClientId enabled in zk config.

Copy link
Collaborator

@rahulrane50 rahulrane50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
Let's also follow a practice to update local testing results in PR request so that we both won't miss this until we deploy things in EI :)

@mgao0 mgao0 merged commit 2ae6587 into linkedin:li-dev/base-3.6.3-znode-group-security Aug 23, 2022
@mgao0 mgao0 deleted the authInfo branch August 23, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants