refactor(app/test): remove unused test Server interfaces
#3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this `Server` type is not used by any tests. this commit removes it, to help facilitate the upgrade to the hyper 1.0 major release. see <linkerd/linkerd2#8733>. Signed-off-by: katelyn martin <[email protected]>
cratelyn
commented
Dec 4, 2024
| use tokio::task::JoinHandle; | ||
| use tower::{util::ServiceExt, Service}; | ||
| use tracing::Instrument; | ||
|
|
||
| #[allow(deprecated)] // linkerd/linkerd2#8733 | ||
| use hyper::client::conn::{Builder as ClientBuilder, SendRequest}; | ||
|
|
||
| pub struct Server { | ||
| #[allow(deprecated)] // linkerd/linkerd2#8733 |
There was a problem hiding this comment.
this is cherry-picked out of a draft branch i've been working on, addressing deprecated client connection interfaces. this type isn't used, so we can save ourselves the trouble and remove this type altogether.
olix0r
approved these changes
Dec 4, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this
Servertype is not used by any tests.this commit removes it, to help facilitate the upgrade to the hyper 1.0 major release. see linkerd/linkerd2#8733.