Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lint and check command #1276

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Jan 12, 2022

Signed-off-by: Takumi Sue [email protected]

Copy link
Contributor

@cpretzer cpretzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @mikutas

Does it make sense to add the rm -rf tmp to make lint or make check? If we want to rebuild the files before either of those commands, then maybe we should add the command then we could remove the files first.

If not, then this PR looks good

@mikutas
Copy link
Contributor Author

mikutas commented Jan 13, 2022

tried to show example...

Example

The branch_a has no problem so we expect make check always reports no error.

The branch_b contains a wrong file. If we are on branch_b, make check fails (as expected).
branch_a doesn't contain the wrong file.

When we run make check on branch_b and move to branch_a, tmp still contains the wrong file (because git ignored).
Then we run make check on branch_a, it fails despite branch_a has no problem (because tmp-sites overwrites only files belonging to branch_a).

@mikutas mikutas requested a review from cpretzer January 14, 2022 02:23
Copy link
Contributor

@cpretzer cpretzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mikutas I appreciate the PR and the explanation/example

@cpretzer cpretzer merged commit d1eb6e0 into linkerd:main Jan 28, 2022
@mikutas mikutas deleted the update_readme branch September 18, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants