Prometheus basic-auth fixes #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflynn
force-pushed
the
jadkhaddad-1659
branch
from
c1b75bb to
f62c3b7
Compare
Problem: In the documentation explaining the usage of an external Prometheus, the protocol is missing in provided example. This is causing Viz to be unable to establish communication with the external Prometheus, resulting in a "unsupported protocol" error message in the logs. Solution: added protocol and basic auth to prometheus url Fixes #1658 Signed-off-by: JadKHaddad <[email protected]>
Signed-off-by: JadKHaddad <[email protected]>
Signed-off-by: Flynn <[email protected]>
Co-authored-by: Alejandro Pedraza <[email protected]> Signed-off-by: Flynn <[email protected]>
Co-authored-by: Alejandro Pedraza <[email protected]> Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
kflynn
force-pushed
the
jadkhaddad-1659
branch
from
f62c3b7 to
71ee829
Compare
alpeb
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally by @JadKHaddad in #1659, thanks!