Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing 'upgrade' field to DC migration endpoint #592

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add missing 'upgrade' field to DC migration endpoint #592

merged 4 commits into from
Oct 29, 2024

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added the missing 'upgrade' field to DC migration endpoint and added tests.

✔️ How to Test

make fixtures ARGS="-run TestInstance_Migrate"

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner October 23, 2024 20:27
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team October 23, 2024 20:27
ykim-akamai
ykim-akamai approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start adding unit tests along with integration tests? Giving an approval for now if you want to merge this PR first then you can create a ticket and assign it to me. Nice work!

@ezilber-akamai
Copy link
Contributor Author

Do we want to start adding unit tests along with integration tests? Giving an approval for now if you want to merge this PR first then you can create a ticket and assign it to me. Nice work!

Added unit tests!

@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Oct 28, 2024
lgarber-akamai
lgarber-akamai approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixtures are passing locally on my end, nice work!

@ezilber-akamai ezilber-akamai merged commit f562be3 into linode:main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykim-akamai ykim-akamai ykim-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@jriddle-linode jriddle-linode Awaiting requested review from jriddle-linode jriddle-linode is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezilber-akamai @lgarber-akamai @ykim-akamai