Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for migrations field for Placement Groups #617

Merged

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Nov 13, 2024

📝 Description

Added support for migrations field for Placement Groups and added unit and integration tests.

✔️ How to Test

make fixtures ARGS="-run TestInstance_MigrateToPG"
make testunit

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner November 13, 2024 21:26
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team November 13, 2024 21:26
@ezilber-akamai ezilber-akamai force-pushed the TPT-3181-support-pg-migrations-field branch from bd00b0e to 7a2c05b Compare November 14, 2024 15:59
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Nov 14, 2024
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working locally!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passing locally

@ezilber-akamai ezilber-akamai merged commit d7dbe30 into linode:main Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants