refactor: [M3-6285] - SRC > Features > ToastNotifications #9555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class ToastNotifications extends React.PureComponent<WithSnackbarProps, {}> { | ||
| componentDidMount() { | ||
| this.subscription = events$ | ||
| export const ToastNotifications = withSnackbar((props: WithSnackbarProps) => { |
There was a problem hiding this comment.
We can use the useSnackbar hook instead of using this withSnackbar wrapper.
bnussman-akamai
approved these changes
Aug 23, 2023
bnussman-akamai
added
Add'tl Approval Needed
cpathipa
approved these changes
Aug 24, 2023
cpathipa
approved these changes
Aug 24, 2023
bnussman-akamai
added
Approved
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* initial migration changes * Added changeset: SRC > Features > ToastNotifications MUI v5 migration * removed default export * updated useEffect dependency array * deleted unnecessary comment * replaced ToastNotification withSnackbar to useSnackbar --------- Co-authored-by: TylerWJ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
SRC > Features > ToastNotifications MUI v5 migration
Toast Notifications that don't work in production (I will be adding a ticket for these):
Also, sorry for the inconsistent preview pictures, I had to quickly snap them before they went away. 📸 🏃♂️💨
Major Changes 🔄
Preview 📷
How to test 🧪
Test the following toast notifications: