Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-6264] - MUI v5 Migration - SRC > Features > Events #9565

Merged
merged 8 commits into from
Aug 28, 2023
Merged

refactor: [M3-6264] - MUI v5 Migration - SRC > Features > Events #9565

merged 8 commits into from
Aug 28, 2023

Conversation

tyler-akamai
Copy link
Contributor

@tyler-akamai tyler-akamai commented Aug 18, 2023 •
edited
Loading

Description 📝

MUI v5 CSS migration for SRC > Features > Events

Major Changes 🔄

  • Eliminated default exports
  • Eliminated makeStyles
  • Renamed props
  • Created .styles files

Preview 📷

Before After
Screenshot 2023-08-22 at 3 05 02 PM Screenshot 2023-08-22 at 3 03 44 PM

How to test 🧪

  1. Navigate to http://localhost:3000/events
  2. Ensure the styling is consistent

@tyler-akamai tyler-akamai self-assigned this Aug 18, 2023
@tyler-akamai tyler-akamai changed the title refactor: [M3-6264] - SRC > Features > Events refactor: [M3-6264] - MUI v5 Migration - SRC > Features > Events Aug 18, 2023
@tyler-akamai tyler-akamai marked this pull request as ready for review August 22, 2023 19:13
coliu-akamai
coliu-akamai reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! just had a few comments

packages/manager/src/features/Events/EventRow.tsx Outdated Show resolved Hide resolved
packages/manager/src/features/Events/EventsRow.styles.ts Outdated Show resolved Hide resolved
packages/manager/src/features/Events/EventsRow.styles.ts Outdated Show resolved Hide resolved
packages/manager/src/features/Events/EventsRow.styles.ts Outdated Show resolved Hide resolved
@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 25, 2023
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 28, 2023
@tyler-akamai tyler-akamai merged commit acb2035 into linode:develop Aug 28, 2023
@bnussman-akamai bnussman-akamai mentioned this pull request Sep 5, 2023
Merged
@tyler-akamai tyler-akamai deleted the M3-6264-Events-CSS-Migration branch September 5, 2023 15:53
@bnussman-akamai bnussman-akamai mentioned this pull request Sep 5, 2023
Merged
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
@tyler-akamai @TylerWJ @corya-akamai
refactor: [M3-6264] - MUI v5 Migration - SRC > Features > Events (lin…
fa2e0b9 
…ode#9565)

* initial migration changes

* Added changeset: MUI v5 Migration - SRC > Features > Events

* fixed label alignement issue

* fixed pr suggestions

* removed render guard in EventRow

---------

Co-authored-by: TylerWJ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai left review comments

@cpathipa cpathipa cpathipa approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

Assignees

@tyler-akamai tyler-akamai

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tyler-akamai @bnussman-akamai @cpathipa @coliu-akamai @TylerWJ