fix: create-volume.spec.ts and dynamicPricing.test.ts
#9578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
e2e
bnussman-akamai
added
Add'tl Approval Needed
|
@bnussman updated the failing unit test as well in there. It needs to be dynamic (will do a follow up) but going for the quick turnaround now |
|
Thanks! You beat me to it! @abailly-akamai |
bnussman-akamai
changed the title
create-volume.spec.ts selecting incorrect elementcreate-volume.spec.ts and dynamicPricing.test.ts
|
Really struggling to get e2es to run in jenkins today. Looking for 1 more approval |
mjac0bs
approved these changes
Aug 22, 2023
bnussman-akamai
added
Approved
coliu-akamai
pushed a commit
to coliu-akamai/manager
that referenced
this pull request
Aug 23, 2023
* select region select differently * run test with the `dcSpecificPricing` off * fix test since calc was recently updated * fix unit tests * Added changeset: Fix volume e2e test and dc specific price unit test --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Alban Bailly <[email protected]>
This was referenced Sep 5, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* select region select differently * run test with the `dcSpecificPricing` off * fix test since calc was recently updated * fix unit tests * Added changeset: Fix volume e2e test and dc specific price unit test --------- Co-authored-by: Banks Nussman <[email protected]> Co-authored-by: Alban Bailly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
create-volume.spec.tsby selecting the Region select differently. The copy was being selected because it now contains "Select a Volume" after changes in feat: [M3-6971] Add dynamic pricing model to Volume creation flows #9569How to test 🧪
yarn cy:debugcreate-volume.spec.ts