feat: [M3-6821] - AGLB Details - Settings Tab #9583
Conversation
bnussman-akamai
added
Ready for Review
Missing Changeset
and removed
Missing Changeset
labels
There was a problem hiding this comment.
Updating a label and deleting the load balancer is working as expected. ✅
This is not really right place to mention this as it's not related to this ticket, but I just noticed it and didn't want to forget about it. The "Create Loadbalancer" button has Load Balancer as one word and elsewhere (+ in the mocks) we have it as two words. We should probably check for consistency throughout the pages in case it's one word anywhere else.
bnussman-akamai
added
Add'tl Approval Needed
|
When you update the label, should the label be updated in the landing page? becuase the breadcrumb updates for me but not the landing page: Screen.Recording.2023-08-24.at.9.08.35.AM.mov |
nvm forgot this is the MSW |
bnussman-akamai
added
Approved
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Show resolved
Hide resolved
| <Button | ||
| buttonType="primary" | ||
| onClick={() => setIsDeleteDialogOpen(true)} | ||
| type="submit" | ||
| > | ||
| Delete | ||
| </Button> |
There was a problem hiding this comment.
Can we leverage the ActionsPanel component here?
There was a problem hiding this comment.
Because it is left aligned and just one button, I think a singular button is okay here.
There was a problem hiding this comment.
Agree, unless if ActionsPanel doesn't support. I think we could align it using justifyContent="flex-start". My only concern is that we might want to avoid or minimize multiple references to the primary button.
packages/manager/src/features/LoadBalancers/LoadBalancerLanding/LoadBalancerLanding.tsx
Show resolved
Hide resolved
* inital build of settings * Added changeset: Add AGLB Details - Settings Tab * fix the create button * fix e2e tests --------- Co-authored-by: Banks Nussman <[email protected]>
Description 📝
Major Changes 🔄
http://localhost:3000/loadbalancers/5/summaryPreview 📷
How to test 🧪
http://localhost:3000/loadbalancers/5/summary