chore: Update Material UI and Emotion #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
jdamore-linode
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Nice! Can't believe how quickly that MUI fix got released.
A couple observations, but nothing that I think requires any action:
- The menus without scroll lock don't seem to play very nicely with MacOS scroll elasticity/bouncing, but I haven't looked too closely at it and I kind of doubt there's much we can do about it
- The user menu still locks scrolling -- is that intentional or would we want to use
disableScrollLockhere too now that we can? I don't have any opinion from a UX perspective
bnussman-akamai
added
Add'tl Approval Needed
cpathipa
approved these changes
Aug 30, 2023
bnussman-akamai
added
Approved
|
I'll be sure to follow up about the other Menus causing scroll lock @jdamore-linode. The MacOS scroll bounce is unfortunate. I'll keep an eye out for fixes for that. |
This was referenced Sep 1, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* update MUI and style libraries and allow scroll with actionmenu * fix some deprecated props * Added changeset: Update Material UI and Emotion --------- Co-authored-by: Banks Nussman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
latest<ActionMenu />use MUI instead of Reach UI #9540 (comment)Preview 📷
Screen.Recording.2023-08-29.at.2.10.13.PM.mov
Screen.Recording.2023-08-29.at.2.09.47.PM.mov
How to test 🧪
yarnfor good measureyarn devand verify the app works and looks normal