Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename src/features/VPC to src/features/VPCs #9604

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

dwiley-akamai
Copy link
Contributor

Description 📝

Updated per #9530 (review) to be consistent with directory naming pattern for other entities

How to test 🧪

Confirm that the relevant files were renamed and imports updated where necessary

@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Aug 29, 2023
@dwiley-akamai dwiley-akamai self-assigned this Aug 29, 2023
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🎉

some nitpicks, feel free to ignore

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 29, 2023
@coliu-akamai
Copy link
Contributor

coliu-akamai commented Aug 29, 2023

Oh one other thing I just remembered, inside the VPCCreate.tsx file, could you change the header text from "Subnet" to "Subnets" (should be line 238)? Andrew mentioned this on Friday but the VPC Create ticket had been merged in by then

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 29, 2023
@dwiley-akamai dwiley-akamai merged commit 59263c7 into linode:develop Aug 30, 2023
@dwiley-akamai dwiley-akamai deleted the rename-vpc-to-vpcs branch August 30, 2023 13:51
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants