fix: Kube checkout bar copy #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpathipa
approved these changes
Aug 31, 2023
bnussman-akamai
added
Add'tl Approval Needed
|
Did you branch off an old develop? |
bnussman-akamai
approved these changes
Aug 31, 2023
bnussman-akamai
added
Approved
Hmm, no, I've pulled the current |
|
I'm going to go ahead and merge this since this is really a small copy and prop change and shouldn't have any impact on e2es. |
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* Update copy and pass in as prop * Fix test and create a constant * I didn't actually finish updating the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Clarifies that HA selection is also needed to create a cluster. Also moves the copy to a prop because it shouldn't have been in
CheckoutBar, a core component.Relates to changes made in #9568 and #9489.
Still not sure that user feedback in this form is ideal because if a user selects a node pool and a region, the text is replaced with the price and user still can't submit without an HA selection.
Preview 📷
How to test 🧪
Play around with the kube create form, selecting HA, region, and node pool options.