-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [M3-7042] - DC-Specific Pricing Copy and Link Cleanup #9670
chore: [M3-7042] - DC-Specific Pricing Copy and Link Cleanup #9670
Conversation
I agree with the global recommendations. Here are a couple questions about specific use cases:
|
Chatted about this: The most accurate grammar version should be "Data Center-Specific" and "data center-specific" with a hyphen between "center" and "specific". |
Thanks @matthewbartholomew and @jddocs - I made that change. And yes, @matthewbartholomew, I left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice having a technical writer for these nuances! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
Description 📝
This PR does some clean up for DC pricing and attempts to standardize language for "region" and "data center", both of which have been used throughout this project. As a result, it touches a few other components not directly related to DC pricing in order to rename consistently and avoid running into this problem again in another 6 months.
Changes have been reviewed by UX and Docs.
Major Changes 🔄
Preview 📷
Not DC-pricing specific:
How to test 🧪
Make sure all e2es and unit tests pass -- copy changes might affect tests.