Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-7042] - DC-Specific Pricing Copy and Link Cleanup #9670

Merged

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Sep 13, 2023

Description 📝

This PR does some clean up for DC pricing and attempts to standardize language for "region" and "data center", both of which have been used throughout this project. As a result, it touches a few other components not directly related to DC pricing in order to rename consistently and avoid running into this problem again in another 6 months.

Changes have been reviewed by UX and Docs.

Major Changes 🔄

  • Use "region" rather than "Region" in notices, since the word is not at the beginning of a sentence or labeling a field.
  • Use "data center" rather than "datacenter", since we've previously used both, but "datacenter" was used in copy much less often (only 3 places).
  • Remove the "How Data Center Pricing Works" docs link for now, since it was deemed redundant to display this link while the (temporary) info notice is shown above the Region select.
  • Labels some TODOs with project name and ticket number.

Preview 📷

Before After
Screenshot 2023-09-13 at 8 50 21 AM Screenshot 2023-09-13 at 8 39 24 AM
Screenshot 2023-09-13 at 8 50 15 AM Screenshot 2023-09-13 at 8 38 58 AM
Screenshot 2023-09-13 at 8 51 00 AM Screenshot 2023-09-13 at 8 35 44 AM
Screenshot 2023-09-13 at 8 49 50 AM Screenshot 2023-09-13 at 8 25 57 AM
Screenshot 2023-09-13 at 8 50 40 AM Screenshot 2023-09-13 at 8 16 09 AM
Screenshot 2023-09-13 at 8 50 01 AM Screenshot 2023-09-13 at 8 26 03 AM

Not DC-pricing specific:

Before After
Screenshot 2023-09-13 at 8 51 45 AM Screenshot 2023-09-13 at 8 26 58 AM
Screenshot 2023-09-13 at 8 52 26 AM Screenshot 2023-09-13 at 8 27 30 AM

How to test 🧪

  1. How to setup test environment?
  • Check out this PR.
  • Turn the DC-Specific Pricing flag on and turn the MSW on.
  1. How to verify changes?
  1. How to run Unit or E2E tests?
    Make sure all e2es and unit tests pass -- copy changes might affect tests.

@mjac0bs mjac0bs added UX/UI Changes for UI/UX to review DC-Specific Pricing labels Sep 13, 2023
@mjac0bs mjac0bs self-assigned this Sep 13, 2023
@mjac0bs mjac0bs marked this pull request as ready for review September 13, 2023 15:59
@matthewbartholomew
Copy link

matthewbartholomew commented Sep 13, 2023

I agree with the global recommendations. Here are a couple questions about specific use cases:

  1. Data Center Specific Network Transfer Pools—should there still be a hyphen between Center and Specific? Not sure what that might do to capitalization
  2. Confirming that Current Data Center is title case because it is a label and title case sis our standard for label

@jddocs
Copy link

jddocs commented Sep 13, 2023

Chatted about this: The most accurate grammar version should be "Data Center-Specific" and "data center-specific" with a hyphen between "center" and "specific".

@mjac0bs
Copy link
Contributor Author

mjac0bs commented Sep 13, 2023

Thanks @matthewbartholomew and @jddocs - I made that change.

And yes, @matthewbartholomew, I left Current Data Center in title case to remain consistent with our standards for labels.

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice having a technical writer for these nuances! 🚀

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 13, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing UX/UI Changes for UI/UX to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants