fix: [M3-7151] - Redis trademark changes #9694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmorris3293
requested review from
mjac0bs and
bnussman-akamai
and removed request for
a team
hana-akamai
changed the title
hana-akamai
changed the title
…C-specific pricing (linode#9674) * Move billing and payment tests to their own directory * Refactor billing activity smoke tests * Add invoice-related QA data attributes * Add pagination-related QA data attributes * Add invoice tests
* feat: [M3-7141] add codeowner file to monorepo root * feat: [M3-7141] change team name
…oices, DC-specific pricing (linode#9674)" This reverts commit 1fa778f.
)" This reverts commit 214e631.
hana-akamai
force-pushed
the
redistrade
branch
from
6437396 to
efdfba7
Compare
bnussman-akamai
approved these changes
Sep 18, 2023
mjac0bs
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Are these fields also in need of the trademark in the Marketplace App for Redis® Sentinel Cluster Setup?
Confirmed:
✅ Mentions of Redis® include a trademark
✅ Searching still displays the two apps (both by search bar and by category - Databases)
✅ Drawer still opens and there is a legal disclaimer in the drawer - had a minor question about the quotes around the legal disclaimer, but nothing to hold up the release
✅ Logo should be replaced by 3 generic stacked slices
✅ Guide link redirects as expected
|
@mjac0bs Holden will look into the Setup inputs asynchronously |
hana-akamai
changed the title
hana-akamai
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added Redis Legal verbiage to the app descriptions and any instance of Redis includes the Trademark logo
Preview 📷
How to test 🧪
/linodes/create?type=One-Click