Added FirewallD support to scripts #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #387. |
dbaluta
approved these changes
Apr 5, 2024
freysteinn
force-pushed
the
linux-kernel-lab-firewalld
branch
from
b426fe2 to
94ddbd3
Compare
|
The cleanup-net.sh script uses a different device variable name than the create_net.sh script. Cleanup uses $i, but create uses $device. To prevent us from having to do the pull-request walk of shame in case it goes past us, I decided to make both scripts follow the same convention for the future. TL;DR |
|
This should fix #241 as well. |
The default action on Fedora and RHEL-based distributions that use
FirewallD is to ban DHCP requests. Instead of telling people to turn off
their firewall, I recommend adding the tap interfaces to the FirewallD
trusted zone.
This commit adds automatic support to the create_net.sh and
cleanup-net.sh scripts that set up the tap interfaces. Due to many
distributions using FirewallD these days, I opted for using the
following command to check if FirewallD is available:
if [ -e $(which --skip-alias firewall-cmd) ]; then
sudo firewall-cmd --zone=trusted --change-interface=$device
fi
However, we will have to create a better solution for this in the
future.
Signed-off-by: Frey Alfredsson <[email protected]>
freysteinn
force-pushed
the
linux-kernel-lab-firewalld
branch
from
94ddbd3 to
007bb7a
Compare
|
Apart from waiting, is there anything else I need to do? |
dbaluta
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default action on Fedora and RHEL-based distributions that use FirewallD is to ban DHCP requests. Instead of telling people to turn off their firewall, I recommend adding the tap interfaces to the FirewallD trusted zone.
This commit adds automatic support to the create_net.sh and cleanup-net.sh scripts that set up the tap interfaces. Due to many distributions using FirewallD these days, I opted for using the following command to check if FirewallD is available:
However, we will have to create a better solution for this in the future.