Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHELPLAN-56489 - Collection - script - merge 2 python files into one #22

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

nhosoi
Copy link
Contributor

@nhosoi nhosoi commented Oct 12, 2020

  • Merging ansible_role_parser.py into lsr_role2collection.py.
  • Putting the main part of lsr_role2collection.py into main() function
    and call it 'if name == "main"'.
  • Adjusting unittests to the refactored functions.

- Merging ansible_role_parser.py into lsr_role2collection.py.
- Putting the main part of lsr_role2collection.py into main() function
  and call it 'if __name__ == "__main__"'.
- Adjusting unittests to the refactored functions.
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nhosoi nhosoi merged commit ccdf028 into linux-system-roles:master Oct 12, 2020
@nhosoi
Copy link
Contributor Author

nhosoi commented Oct 12, 2020

Thank you, @richm. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants