Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHELPLAN-59755 - Collection - script - not include symlinks in the co… #33

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

nhosoi
Copy link
Contributor

@nhosoi nhosoi commented Dec 8, 2020

In the commit 6442eaf, symlinks in the
tests dir are converted to the real files and directories including
the module_utils, which is not preferable. With this commit, such sym-
links targeting the outside of the tests are removed. Only symlinks
which points inside the tests are untouched. For instance,
lrwxrwxrwx. <> network/tests/playbooks/files -> ../files/

richm
richm previously approved these changes Dec 8, 2020
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…llection converted format

In the commit 6442eaf, symlinks in the
tests dir are converted to the real files and directories including
the module_utils, which is not preferable. With this commit, such sym-
links targeting the outside of the tests are removed. Only symlinks
which points inside the tests are untouched. For instance,
lrwxrwxrwx. <<snip>> network/tests/playbooks/files -> ../files/
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nhosoi nhosoi merged commit 5c7252e into linux-system-roles:master Dec 8, 2020
@nhosoi
Copy link
Contributor Author

nhosoi commented Dec 8, 2020

Thank you, @richm. Merged.

@nhosoi nhosoi deleted the symlinks branch April 20, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants