Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Write lease validity #259

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: Write lease validity #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d424705
feat: Implement WRITE_LEASE_VALIDITY
spetrosi Feb 16, 2024
91db3bf
Fix indentation in yaml
spetrosi Feb 16, 2024
cc5e078
Use WRITE_LEASE_VALIDITY=10
spetrosi Feb 16, 2024
a57168c
Fix typo s/on_fail/on-fail/g
spetrosi Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 65 additions & 59 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,31 +1031,31 @@ For more information, see the `fedora.linux_system_roles.ha_cluster` role docume
ha_cluster_sbd_enabled: true
ha_cluster_cluster_properties:
- attrs:
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-watchdog-timeout
value: 10
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-watchdog-timeout
value: 10
ha_cluster_resource_primitives:
- id: ag_cluster
agent: ocf:mssql:ag
instance_attrs:
- attrs:
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
meta_attrs:
- attrs:
- name: failure-timeout
value: 60s
- name: failure-timeout
value: 60s
- id: virtualip
agent: ocf:heartbeat:IPaddr2
instance_attrs:
- attrs:
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
operations:
- action: monitor
attrs:
Expand All @@ -1066,8 +1066,10 @@ For more information, see the `fedora.linux_system_roles.ha_cluster` role docume
promotable: yes
meta_attrs:
- attrs:
- name: notify
value: true
- name: notify
value: true
- name: on-fail
value: demote
ha_cluster_constraints_colocation:
- resource_leader:
id: ag_cluster-clone
Expand Down Expand Up @@ -1125,41 +1127,41 @@ Note that production environments require Pacemaker configured with fencing agen
ha_cluster_hacluster_password: "p@55w0rD4"
ha_cluster_cluster_properties:
- attrs:
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
ha_cluster_resource_primitives:
- id: vmfence
agent: stonith:fence_vmware_soap
instance_attrs:
- attrs:
- name: username
value: vmware_Login
- name: passwd
value: vmware_password
- name: ip
value: vmware_ip
- name: ssl_insecure
value: 1
- name: username
value: vmware_Login
- name: passwd
value: vmware_password
- name: ip
value: vmware_ip
- name: ssl_insecure
value: 1
- id: ag_cluster
agent: ocf:mssql:ag
instance_attrs:
- attrs:
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
meta_attrs:
- attrs:
- name: failure-timeout
value: 60s
- name: failure-timeout
value: 60s
- id: virtualip
agent: ocf:heartbeat:IPaddr2
instance_attrs:
- attrs:
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
operations:
- action: monitor
attrs:
Expand All @@ -1170,8 +1172,10 @@ Note that production environments require Pacemaker configured with fencing agen
promotable: yes
meta_attrs:
- attrs:
- name: notify
value: true
- name: notify
value: true
- name: on-fail
value: demote
ha_cluster_constraints_colocation:
- resource_leader:
id: ag_cluster-clone
Expand Down Expand Up @@ -1243,33 +1247,33 @@ This example playbooks sets the `firewall` variables for the `fedora.linux_syste
- fence-agents-azure-arm
ha_cluster_cluster_properties:
- attrs:
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-timeout
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-timeout
value: 900
ha_cluster_resource_primitives:
- id: rsc_st_azure
agent: stonith:fence_azure_arm
instance_attrs:
- attrs:
- name: login
value: ApplicationID
- name: passwd
value: servicePrincipalPassword
- name: resourceGroup
value: resourceGroupName
- name: tenantId
value: tenantID
- name: subscriptionId
value: subscriptionID
- name: power_timeout
value: 240
- name: pcmk_reboot_timeout
value: 900
- name: login
value: ApplicationID
- name: passwd
value: servicePrincipalPassword
- name: resourceGroup
value: resourceGroupName
- name: tenantId
value: tenantID
- name: subscriptionId
value: subscriptionID
- name: power_timeout
value: 240
- name: pcmk_reboot_timeout
value: 900
- id: azure_load_balancer
agent: azure-lb
instance_attrs:
Expand Down Expand Up @@ -1310,6 +1314,8 @@ This example playbooks sets the `firewall` variables for the `fedora.linux_syste
- attrs:
- name: notify
value: true
- name: on-fail
value: demote
ha_cluster_constraints_colocation:
- resource_leader:
id: ag_cluster-clone
Expand Down
6 changes: 6 additions & 0 deletions tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,6 +1035,12 @@
any_errors_fatal: true
when: mssql_ha_configure | bool
block:
# Required for configure_ag.j2 to set WRITE_LEASE_VALIDITY based on
# mssql-server version
- name: Get mssql-server version to see if WRITE_LEASE_VALIDITY is available
package_facts:
no_log: "{{ __mssql_gather_facts_no_log | d(false) }}"

- name: Verify that hosts with mssql_ha_replica_type=primary is available
assert:
that: ansible_play_hosts |
Expand Down
6 changes: 5 additions & 1 deletion templates/configure_ag.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,11 @@ BEGIN
CREATE AVAILABILITY GROUP {{ mssql_ha_ag_name }}
WITH (
DB_FAILOVER = {{ __mssql_ha_db_failover }},
CLUSTER_TYPE = {{ mssql_ha_ag_cluster_type }}
CLUSTER_TYPE = {{ mssql_ha_ag_cluster_type }},
{% if ansible_facts.packages['mssql-server'][0]['version']
is version('15.0.4153.1', '>=') %}
WRITE_LEASE_VALIDITY=10
{% endif %}
)
FOR REPLICA ON
{# Sort ansible_play_hosts #}
Expand Down
34 changes: 18 additions & 16 deletions tests/tests_configure_ha_cluster_external.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,31 +49,31 @@
ha_cluster_sbd_enabled: true
ha_cluster_cluster_properties:
- attrs:
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-watchdog-timeout
value: 10
- name: cluster-recheck-interval
value: 2min
- name: start-failure-is-fatal
value: true
- name: stonith-enabled
value: true
- name: stonith-watchdog-timeout
value: 10
ha_cluster_resource_primitives:
- id: ag_cluster
agent: ocf:mssql:ag
instance_attrs:
- attrs:
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
- name: ag_name
value: "{{ mssql_ha_ag_name }}"
meta_attrs:
- attrs:
- name: failure-timeout
value: 60s
- name: failure-timeout
value: 60s
- id: virtualip
agent: ocf:heartbeat:IPaddr2
instance_attrs:
- attrs:
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
- name: ip
value: "{{ mssql_ha_virtual_ip }}"
operations:
- action: monitor
attrs:
Expand All @@ -84,8 +84,10 @@
promotable: true
meta_attrs:
- attrs:
- name: notify
value: true
- name: notify
value: true
- name: on-fail
value: demote
ha_cluster_constraints_colocation:
- resource_leader:
id: ag_cluster-clone
Expand Down
Loading