feat: Add mssql_tools_versions, mssql_tls_self_sign to allow installing different versions of mssql-tools #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[citest] |
richm
reviewed
Nov 6, 2024
richm
reviewed
Nov 6, 2024
richm
reviewed
Nov 6, 2024
richm
reviewed
Nov 6, 2024
richm
reviewed
Nov 6, 2024
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
4786eb2 to
be96f82
Compare
|
[citest] |
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
be96f82 to
3923eec
Compare
|
[citest] |
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
3923eec to
e857b41
Compare
|
[citest] |
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
e857b41 to
c6124bb
Compare
|
[citest] |
Microsoft added a new version of the `mssql-tools` package - `mssql-tools18`. This package adds some new functionality, which is not backward-compatible with the previous versions, hence Microsoft added a new package `mssql-tools18` instead of just bumping the version of `mssql-tools`.
* Move configuring TLS encryption earlier in the role because it's required for sqlcmd on mssql-tools18 * If TLS encryption is not configured, append -C to sqlcmd * TODO: if encryption is configured with self-signed keys - append -C
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
c6124bb to
c939176
Compare
|
[citest] |
3 similar comments
|
[citest] |
|
[citest] |
|
[citest] |
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
9e9f377 to
a522161
Compare
|
[citest] |
Append either -C or -No to sqlcmd Add mssql_tls_self_sign to all tls tests
spetrosi
force-pushed
the
mssql_tools_vers
branch
from
a522161 to
5b28547
Compare
|
[citest] |
1 similar comment
|
[citest] |
spetrosi
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add
mssql_tools_versionsvariable to allow installing different versions ofmssql-toolspackage.Add
mssql_tls_self_signvariable for specifying whether self-signed certificates are used, applicable when users setmssql_tls_enable: true.Reason: Microsoft added a new version of the
mssql-toolspackage -mssql-tools18. This package adds some new functionality, which is not backward-compatible with the previous versions, hence Microsoft added a new packagemssql-tools18instead of just bumping the version ofmssql-tools.With
mssql-tools18, when self-signed TLS certificates are used, it is required to set-Cflag withsqlcmdto trust certificates.Result: You can set
mssql_tools_versionsto install version 17, 18, or both version in parallel. By default, the role now installs the newer mssql-tools18.With mssql-tools18, when you use self-signed TLS certificates, you must set
mssql_tls_self_sign: trueto make sqlcmd trust your certificates.Issue Tracker Tickets (Jira or BZ if any): https://issues.redhat.com/browse/SYSROLES-166