Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring changes to build with clang15 and master branch of oe-core #226

Closed
wants to merge 4 commits into from

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Sep 29, 2022

No description provided.

@kraj kraj changed the title Yoe/mut Bring changes to build with clang15 and master branch of oe-core Sep 29, 2022
@ldesroches
Copy link
Contributor

Hi,

Concerning EGT, is this move to c++17 mandatory? There is a fallback if the experimental file system is not detected. Maybe this fallback is not working as expected... We are considering making this move but we don't want to do it in a rush.

Regards

@kraj
Copy link
Contributor Author

kraj commented Oct 6, 2022

Hi,

Concerning EGT, is this move to c++17 mandatory? There is a fallback if the experimental file system is not detected. Maybe this fallback is not working as expected... We are considering making this move but we don't want to do it in a rush.

This was a path to fix build with clang 15+ where libc++ has started to drop older features, if we can fix it in other ways thats ok too.

Regards

@kraj
Copy link
Contributor Author

kraj commented Oct 11, 2022

Can you cherry-pick the layer compat patches ? they are now needed

@noglitch
Copy link
Member

@Dharma-B , @gehariprasath : some patches to queue for the dunfell branch before that we move "master" to kirkstone, probably

@gehariprasath
Copy link
Contributor

gehariprasath commented Oct 12, 2022

Can you cherry-pick the layer compat patches ? they are now needed

We will apply the same and the other patch for cryptoauthlib after review.

kraj added 2 commits October 12, 2022 07:53
With c++17 we can now use filesystem from std, since its no more
experimental

Signed-off-by: Khem Raj <[email protected]>
@gehariprasath
Copy link
Contributor

@kraj The cryptoauthlib has the manual document which is part of the repository, hence we cannot skip it. Installing git-lfs in the host machine is an easier option.

kraj added a commit to YoeDistro/docker-yoe-build that referenced this pull request Oct 13, 2022
Some layers like meta-atmel needs them [1]

[1] linux4sam/meta-atmel#226 (comment)

Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to YoeDistro/docker-yoe-build that referenced this pull request Oct 13, 2022
Some layers like meta-atmel needs them [1]

[1] linux4sam/meta-atmel#226 (comment)

Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to YoeDistro/docker-yoe-build that referenced this pull request Oct 13, 2022
Some layers like meta-atmel needs them [1]

[1] linux4sam/meta-atmel#226 (comment)

Signed-off-by: Khem Raj <[email protected]>
@kraj
Copy link
Contributor Author

kraj commented Oct 13, 2022

@kraj The cryptoauthlib has the manual document which is part of the repository, hence we cannot skip it. Installing git-lfs in the host machine is an easier option.

OK, I have dropped the concerned patch from pull here.

kraj added 2 commits December 31, 2022 10:35
It houses hayai as a submodule, and it fails to build because hayai.h is
missing. The reason is that the sources are not fetched properly.
therefore use gitsm fetcher so it can fetch the hayai submodule and use
it during build

Fixes
'./'`src/main.cpp
src/main.cpp:7:10: fatal error: 'hayai.hpp' file not found
         ^~~~~~~~~~~
1 error generated.
make[1]: *** [Makefile:513: src/benchmark-main.o] Error 1

Signed-off-by: Khem Raj <[email protected]>
@noglitch
Copy link
Member

noglitch commented Jan 5, 2023

I think this one can be closed as well.

@noglitch noglitch closed this Jan 5, 2023
@kraj
Copy link
Contributor Author

kraj commented Jan 5, 2023

@noglitch I still have egt patches but I will open a new PR for that

kraj added a commit to YoeDistro/docker-yoe-build that referenced this pull request Apr 26, 2023
Some layers e.g. meta-atmel [1] needs it

[1] linux4sam/meta-atmel#226 (comment)

Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants