Fix libegt/egt-launcher with clang/libc++ #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With c++17 we can now use filesystem from std, since it has been promoted from experimental to standard library Signed-off-by: Khem Raj <[email protected]>
…ystem Signed-off-by: Khem Raj <[email protected]>
|
Hello Khem Thanks for your patch. Pls be assured that this is being looked at with our internal EGT team and we will respond to this at the earliest. |
|
Thanks, for these patches. It's fine, PR can be merged. |
|
Merged. Thanks @kraj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noglitch support for std::filesystem is still needed to get the latest libegt working. using c++17 is fixed in this version which is great but code for experimental::filesystem also needs to change