-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu-coreboot-fbwhiptail board addition #708
qemu-coreboot-fbwhiptail board addition #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is adding a new board specifically for the GUI / fbwhiptail case, can go ahead and drop all the commented config items for text mode, as well the comments regarding choosing between the two
@MrChromebox done |
aafdf66
to
2c5c64a
Compare
@MrChromebox : Agreed. those comments should be made to #516 and/or #701 which would need to be filled in for another PR to be made consequently (swtpm support, disk support, host usb support passthrough...). This is just basic board config which would benefit from love given in the two other issues pointed above.
Fixed. Thanks. |
I'm still seeing the first commit as:
the most recent force push only changed the 2nd commit |
…e BOARD=qemu-coreboot-fbwhiptail run
2c5c64a
to
29e2800
Compare
@MrChromebox fixed. |
by doing:
make BOARD=qemu-coreboot-fbwhiptail && make BOARD=qemu-coreboot-fbwhiptail run
One can test gui-init
Based on #707