Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xdg icon loading failed with qt6 #213

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

kegechen
Copy link
Contributor

fallback to QIconLoaderEngine on DTK_DISABLE_LIBXDG

Issue: linuxdeepin/developer-center#6459

fallback to QIconLoaderEngine on DTK_DISABLE_LIBXDG

Issue: linuxdeepin/developer-center#6459
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 19, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#213
@kegechen
Copy link
Contributor Author

kegechen commented Dec 19, 2023

image

之前之所以找不到是xdg没有适配qt6, 但是qt6有自己找图标的 QIconLoaderEngine ,这里如果禁用了xdg DTK_DISABLE_LIBXDG 就回退到 QIconLoaderEngine

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 19, 2023

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 8cabfe8 into linuxdeepin:master Dec 20, 2023
19 of 21 checks passed
kegechen pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Dec 20, 2023
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants