Non-EFI systems are misdetected as EFI #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currectly hw-probe detects an EFI system by checking either:
/boot/efidirectory, orefi:line in kernel log.Both methods however, are wrong, leading many non-EFI systems being misdetected.
For the presence of
/boot/efidirectory, it means the system may have a setup that supports booting via EFI; it doesn't necessarily means the running system was booted via EFI.For the
efi:line in kernel log, it only means the running Linux was configured to be EFI-aware. In fact, theefi:line of one of my system is:Which actually indicates that EFI is not being used.
Remove both improper checkings, and check for
/sys/firmware/efidirectory instead.