Stop crashes when RAID devices are present (Issue #70) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #70 where Timeshift crashes if RAID devices are present in the system.
The issue ticket includes analysis of root cause and breakdown of the code changes done. The short version being the original code was heavily dependent on the order of lsblk output and the fix adds logic to specifically identify parent/child relationships instead.
Change has been running for over 6 months on RAID5 and RAID6 configurations with no issues. PR includes the original fix (done against the the Linux Mint 21.1 version of timeshift) together with merges of all changes since.
Not sure what else you need but let me know.
Keith