[Next] Refactor LinuxDistro class #376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygerlach
force-pushed
the
refactorLinuxDistro
branch
from
e427d80 to
670e86d
Compare
clefebvre
changed the title
ygerlach
force-pushed
the
refactorLinuxDistro
branch
from
670e86d to
7185509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #333. So #333 should be merged first. Only the last commit (670e86d) is new.
The class LinuxDistro used to check for the files and then reading them. This is a time-of-check-time-of-use bug. Of cause it would probably never trigger in the open, i guess it is a good idea to get rid of it. Now cases like the file exists, but is not readable (wrong permissions, file type, ...) are also handled. The class also used
string.spliton the same string multiple times. I changed that.I also deduplicted the code used for parsing
/etc/lsb-releaseand/etc/os-releaseand added the removing of leading and trailing"to/etc/os-release(/etc/lsb-releasehad it already)