Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update function restore_current_system() to check that dst_root is not null #386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update function restore_current_system() to check that dst_root is not null #386

wants to merge 1 commit into from

Conversation

Magentron
Copy link

Fixes #278:

Thread 1 "timeshift" received signal SIGSEGV, Segmentation fault.
0x00005555555a2fb9 in main_get_restore_current_system (self=0x555555670010) at ../src/Core/Main.vala:1895
1895					((dst_root.device == sys_root.device) || (dst_root.uuid == sys_root.uuid))){

@Magentron
Update Main.vala function restore_current_system check that dst_root …
d00a2ed 
…is not null

Fixes segmentation fault:

```
Thread 1 "timeshift" received signal SIGSEGV, Segmentation fault.
0x00005555555a2fb9 in main_get_restore_current_system (self=0x555555670010) at ../src/Core/Main.vala:1895
1895					((dst_root.device == sys_root.device) || (dst_root.uuid == sys_root.uuid))){
```
@Magentron
Copy link
Author

Magentron commented Jan 20, 2025 •
edited
Loading

Fixes segmentation vault, but does not solve the real problem, now on restore I get the following (no device nor mount):

[2025-01-20 16:50:18] root@rollback:~# timeshift --restore --verbose --snapshot 2025-01-20_15-31-59 --skip-grub
[Warning] Deleted invalid lock
Mounted '/dev/vda1' at '/run/timeshift/11940/backup'


******************************************************************************
To restore with default options, press the ENTER key for all prompts!
******************************************************************************

Press ENTER to continue...
******************************************************************************
GRUB will NOT be reinstalled
******************************************************************************

======================================================================
WARNING
======================================================================
Data will be modified on following devices:

Device  Mount
------  -----




======================================================================
DISCLAIMER
======================================================================
This software comes without absolutely NO warranty and the author takes no responsibility for any damage arising from the use of this program. If these terms are not acceptable to you, please do not proceed beyond this point!

Continue with restore? (y/n): y
E: Failed to remove directory
Ret=256

@Magentron Magentron changed the title Update Main.vala function restore_current_system check that dst_root is not null Update function restore_current_system() to check that dst_root is not null Jan 20, 2025
@Magentron Magentron mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeshift Segmentation fault on restore.
1 participant
@Magentron