Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add geoip2 #59

Merged
merged 3 commits into from
Feb 18, 2020
Merged

add geoip2 #59

merged 3 commits into from
Feb 18, 2020

Conversation

machsix
Copy link
Contributor

@machsix machsix commented Feb 14, 2020

linuxserver.io


We welcome all PR’s though this doesn’t guarantee it will be accepted.

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

1 similar comment
@aptalca
Copy link
Member

aptalca commented Feb 14, 2020

Thanks for the PR. Just a heads up, Maxminddb is no longer able to download the db without a user api key. So out of the box it no longer works on alpine.

For the letsencrypt image, we had to do this: https://github.com/linuxserver/docker-letsencrypt/blob/master/root/etc/cont-init.d/50-config#L265-L272

@machsix
Copy link
Contributor Author

machsix commented Feb 14, 2020

Yes. But I don't know where to modify the upstream Dockerfile. It's better to include something similar.
There are some third-party providers syncing the database like

  1. https://geolite.clash.dev/
  2. https://github.com/Dreamacro/maxmind-geoip

@aptalca
Copy link
Member

aptalca commented Feb 14, 2020

Hmm, it's likely they may get hit with legal requests to take them down since they are redistributing licensed material. MaxMind is a for profit company with resources.

Keep this open, I'll PR some changes to make it work as long as the user provides the db somehow.

1 similar comment
@aptalca aptalca requested a review from a team February 18, 2020 22:39
@thelamer thelamer merged commit cf2c5bc into linuxserver:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants