-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add geoip2 #59
add geoip2 #59
Conversation
I am a bot, here are the test results for this PR: |
1 similar comment
I am a bot, here are the test results for this PR: |
Thanks for the PR. Just a heads up, Maxminddb is no longer able to download the db without a user api key. So out of the box it no longer works on alpine. For the letsencrypt image, we had to do this: https://github.com/linuxserver/docker-letsencrypt/blob/master/root/etc/cont-init.d/50-config#L265-L272 |
Yes. But I don't know where to modify the upstream Dockerfile. It's better to include something similar. |
Hmm, it's likely they may get hit with legal requests to take them down since they are redistributing licensed material. MaxMind is a for profit company with resources. Keep this open, I'll PR some changes to make it work as long as the user provides the db somehow. |
I am a bot, here are the test results for this PR: |
1 similar comment
I am a bot, here are the test results for this PR: |
I am a bot, here are the test results for this PR: |
We welcome all PR’s though this doesn’t guarantee it will be accepted.
Description:
Benefits of this PR and context:
How Has This Been Tested?
Source / References: