Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard base #79

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Standard base #79

merged 3 commits into from
Aug 22, 2022

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Oct 18, 2021

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

2 similar comments
1 similar comment
@sanmadjack
Copy link

Is this going to be merged any time soon?

@nemchik nemchik added the work-in-progress Stale exempt label Apr 13, 2022
@rtm516
Copy link

rtm516 commented Aug 13, 2022

I've built this container (from this or) myself and am using it in production and it works great for php8 support. Would be nice to use an official image, so any ETA on merging?

@nemchik
Copy link
Member Author

nemchik commented Aug 13, 2022

I've built this container (from this or) myself and am using it in production and it works great for php8 support. Would be nice to use an official image, so any ETA on merging?

Recent changes in linuxserver/docker-baseimage-alpine-nginx#98 resolved some issues that prevented progress. I'm working on linuxserver/docker-swag#169 and it just passed testing. The rest of the downstream images (including this one) will be rebuilt soon. We only have until November to merge before php7 is eol, so I'm fitting it in.

@nemchik nemchik marked this pull request as ready for review August 14, 2022 00:02
@nemchik nemchik requested a review from a team August 14, 2022 00:03
@nemchik nemchik merged commit 437ea22 into master Aug 22, 2022
@nemchik nemchik deleted the standard-base branch August 22, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale exempt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants