Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php-mbstring #91

Closed
wants to merge 3 commits into from
Closed

Conversation

davidnewhall
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds php-mbstring.

Benefits of this PR and context:

So we can deal with multi-lingual utf-8 string more appropriately.

How Has This Been Tested?

Installed it in my container. Seems to work.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@davidnewhall davidnewhall marked this pull request as ready for review March 22, 2023 01:45
2 similar comments
@nemchik
Copy link
Member

nemchik commented Mar 22, 2023

This is already included in the base image https://github.com/linuxserver/docker-baseimage-alpine-nginx/blob/e64cc32d60e7b61e1b1bdf7812f61046585da9dc/Dockerfile#L19 and you can see it is included in this image's list of installed packages

php81-mbstring 8.1.16-r0 apk

@nemchik nemchik closed this Mar 22, 2023
@davidnewhall
Copy link
Author

I'm so confused right now. Thanks!

@davidnewhall davidnewhall deleted the patch-1 branch March 22, 2023 14:13
@aptalca
Copy link
Member

aptalca commented Mar 22, 2023

@davidnewhall we use an baseimage that this image is based on (FROM line in the Dockerfile). A lot of packages are installed there. But if you want to see a list of all the packages included in the final image, see here: https://github.com/linuxserver/docker-nginx/blob/master/package_versions.txt#L136

EDIT: I now see that ix already posted the same link. Oops

@davidnewhall
Copy link
Author

davidnewhall commented Mar 22, 2023

It's not that I don't believe y'all. I'm just confused because when I opened a shell on the nginx container and typed apk add php81-mbstring it sure looked like it installed it. I don't have time right this moment, but I'll be digging in later today to figure out what I'm missing. EDIT: really appreciate the responses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants