-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add php-mbstring #91
add php-mbstring #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR: |
2 similar comments
I am a bot, here are the test results for this PR: |
I am a bot, here are the test results for this PR: |
This is already included in the base image https://github.com/linuxserver/docker-baseimage-alpine-nginx/blob/e64cc32d60e7b61e1b1bdf7812f61046585da9dc/Dockerfile#L19 and you can see it is included in this image's list of installed packages docker-nginx/package_versions.txt Line 136 in c11c0bb
|
I'm so confused right now. Thanks! |
@davidnewhall we use an baseimage that this image is based on (FROM line in the Dockerfile). A lot of packages are installed there. But if you want to see a list of all the packages included in the final image, see here: https://github.com/linuxserver/docker-nginx/blob/master/package_versions.txt#L136 EDIT: I now see that ix already posted the same link. Oops |
It's not that I don't believe y'all. I'm just confused because when I opened a shell on the nginx container and typed |
Description:
Adds
php-mbstring
.Benefits of this PR and context:
So we can deal with multi-lingual utf-8 string more appropriately.
How Has This Been Tested?
Installed it in my container. Seems to work.
Source / References: