Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to 3.21 #263

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Rebase to 3.21 #263

wants to merge 6 commits into from

Conversation

upchui
Copy link
Contributor

@upchui upchui commented Jan 7, 2025

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This pull request updates the base image used for the Docker container. I changed the base image from linuxserver/baseimage-alpine:3.20 to linuxserver/baseimage-alpine:3.21. Additionally, all issues that arose due to this rebase have been fixed.

Benefits of this PR and context:

Rebase to 3.21

How Has This Been Tested?

I have tested it on x64 as well as on aarch64 and it is functional.

Source / References:

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/tvheadend/653bd040-pkg-974d8557-dev-82afb00561376a5eedaa422644a8f6bcf12dd7e1-pr-263/index.html
https://ci-tests.linuxserver.io/lspipepr/tvheadend/653bd040-pkg-974d8557-dev-82afb00561376a5eedaa422644a8f6bcf12dd7e1-pr-263/shellcheck-result.xml

Tag Passed
amd64-653bd040-pkg-974d8557-dev-82afb00561376a5eedaa422644a8f6bcf12dd7e1-pr-263 ✅
arm64v8-653bd040-pkg-974d8557-dev-82afb00561376a5eedaa422644a8f6bcf12dd7e1-pr-263 ✅

Mizokuiam

This comment was marked as off-topic.

Sign in to view

@Mizokuiam
Copy link

This is an interesting point. Have you considered...

@upchui
Copy link
Contributor Author

upchui commented Jan 15, 2025

@Mizokuiam I have no idea what you mean.
Nevertheless, I'm wondering how long the PR will remain open because it's time for something to finally happen.

@j0nnymoe
Copy link
Member

It's time to happen when someone within the team has done the rebase + the container has been tested.

Roxedus
Roxedus requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the contribution guide, update the readme-vars. Direct changes to the readme itself will be overwritten.

@Roxedus
Copy link
Member

Roxedus commented Jan 15, 2025

We aim to also implement non-root support with this alpine release cycle, thus each rebase also taking time, as it need to be tested.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/tvheadend/653bd040-pkg-7ec45f95-dev-964a9cfeb78edcc1d3ff49f233e4eda8a74358ca-pr-263/index.html
https://ci-tests.linuxserver.io/lspipepr/tvheadend/653bd040-pkg-7ec45f95-dev-964a9cfeb78edcc1d3ff49f233e4eda8a74358ca-pr-263/shellcheck-result.xml

Tag Passed
amd64-653bd040-pkg-7ec45f95-dev-964a9cfeb78edcc1d3ff49f233e4eda8a74358ca-pr-263 ✅
arm64v8-653bd040-pkg-7ec45f95-dev-964a9cfeb78edcc1d3ff49f233e4eda8a74358ca-pr-263 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizokuiam Mizokuiam Mizokuiam left review comments

@Roxedus Roxedus Roxedus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Issue & PR Tracker
Status: PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upchui @LinuxServer-CI @Mizokuiam @j0nnymoe @Roxedus