Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only invalidate top level directories #2993

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: only invalidate top level directories #2993

merged 1 commit into from
Nov 6, 2023

Conversation

blacha
Copy link
Member

@blacha blacha commented Nov 6, 2023 •
edited
Loading

Motivation

Deployments currently fail due to too many wildcards, limit the wild cards to the top level directories eg "/docs*" not "/docs/example/foo*"

Modification

Invalidate top level directories and add more logging / debugging information.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@blacha blacha marked this pull request as ready for review November 6, 2023 21:16
@blacha blacha requested a review from a team as a code owner November 6, 2023 21:16
@ajacombs ajacombs added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit c36ab5d Nov 6, 2023
@ajacombs ajacombs deleted the fix/do-not-over-invalidate-cloudfront branch November 6, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajacombs ajacombs ajacombs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blacha @ajacombs