feat: Return 1 when validation fails

linz · Jan 25, 2021 · 62a9ac4 · 62a9ac4
1 parent acde9bf
commit 62a9ac4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/datalake/backend/processing/check_stac_metadata/task.py b/datalake/backend/processing/check_stac_metadata/task.py
@@ -107,10 +107,11 @@ def main() -> int:
 
     try:
         STACSchemaValidator(url_reader).validate(arguments.metadata_url)
-        print(dumps({"success": True, "message": ""}))
     except (AssertionError, ValidationError) as error:
         print(dumps({"success": False, "message": str(error)}))
+        return 1
 
+    print(dumps({"success": True, "message": ""}))
     return 0
 
 

diff --git a/datalake/backend/tests/test_check_stac_metadata.py b/datalake/backend/tests/test_check_stac_metadata.py
@@ -132,7 +132,7 @@ def test_should_print_json_output_on_validation_failure(validate_url_mock) -> No
     sys.argv = [any_program_name(), f"--metadata-url={any_s3_url()}"]
 
     with patch("sys.stdout") as stdout_mock:
-        main()
+        assert main() == 1
 
         assert stdout_mock.mock_calls == expected_calls