This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
fix: Delete vended log groups in ci and non-prod #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vended log groups created by state-machine should be destroyed on stack teardown in ci and non prod environments. This is to keep the number of log groups manageable (especially since new log groups are created with each ci seed).
l0b0
reviewed
Nov 25, 2022
| @@ -82,7 +83,7 @@ def __init__( | |||
| datasets_table: Table, | |||
| git_commit_parameter: aws_ssm.StringParameter, | |||
| ) -> None: | |||
| # pylint: disable=too-many-locals, too-many-statements | |||
| # pylint: disable=too-many-locals, too-many-statements, too-complex | |||
There was a problem hiding this comment.
Looks like this method should be pulled apart. Would you be OK to do that in a separate branch?
There was a problem hiding this comment.
Yes I was thinking the same!
l0b0
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vended log groups created by state-machine should be destroyed on stack teardown in ci and non prod environments. This is to keep the number of log groups manageable (especially since new log groups are created with each ci seed).