fix: handle existing derived_from links when Item is updated TDE-1356 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
changed the title
schmidtnz
requested changes
Dec 18, 2024
schmidtnz
approved these changes
Dec 18, 2024
paulfouquet
deleted the
fix/derived-from-should-not-duplicated-tde-1356
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
🤖 I have created a release *beep* *boop* --- ## [7.1.1](v7.1.0...v7.1.1) (2024-12-18) ### Bug Fixes * handle existing derived_from links when Item is updated TDE-1356 ([#1220](#1220)) ([7dfa7e7](7dfa7e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a published Item with
derived_fromlinks is resupplied, its existing list ofderived_fromlinks may have changed with the resupply. The current implementation would duplicate existingderived_fromlinks and left obsolete ones. It will also remove anyderived_fromlinks in case of the Item is not derived from other Items anymore.Modifications
Remove existing
derived_fromlinks to the STAC Item before processing the currentderived_fromlinks list.Verification
Pytest
Argo Workflows