fix(builder): get stdout/stderr async

lippertmarkus · May 19, 2022 · c05eafa · c05eafa
1 parent 41741f8
commit c05eafa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/Package/Builder/DotNet.cs b/Package/Builder/DotNet.cs
@@ -1,4 +1,5 @@
 using System.Diagnostics;
+using System.Text;
 
 namespace konet.Package.Builder;
 
@@ -29,17 +30,18 @@ public static async Task Build(string targetDirectory, string project, string ru
                 RedirectStandardError = true
             }
         };
+        var stdOut = new StringBuilder();
+        var stdErr = new StringBuilder();
+        p.ErrorDataReceived += (_, dataArgs) => { stdErr.AppendLine(dataArgs.Data ?? string.Empty); };
+        p.OutputDataReceived += (_, dataArgs) => { stdOut.AppendLine(dataArgs.Data ?? string.Empty); };
 
         p.Start();
+        p.BeginErrorReadLine();
+        p.BeginOutputReadLine();
         await p.WaitForExitAsync();
 
         if (p.ExitCode != 0)
-        {
-            var stdOut = await p.StandardOutput.ReadToEndAsync();
-            var stdErr = await p.StandardError.ReadToEndAsync();
-
             throw new DotNetException($"DotNet build failed: \n{stdOut}\n\n{stdErr}");
-        }
     }
 
     public static string DetermineBinaryName(string project)

diff --git a/README.md b/README.md
@@ -41,11 +41,11 @@ dotnet tool update --global konet
 Example:
 
 ```bash
-dotnet new webapi -n mywebapi
-cd mywebapi/
-konet build -t lippertmarkus/test-webapi:1.0
+dotnet new console -n myconsoleapp
+cd myconsoleapp/
+konet build -t lippertmarkus/test-console:1.0
 # ...
-# Successfully pushed to lippertmarkus/test-webapi:1.0
+# Successfully pushed to lippertmarkus/test-console:1.0
 ```
 
 The result is a manifest list at the tag specified in `-t`, referencing images for different architectures with the compiled binary as the entrypoint.
@@ -54,7 +54,7 @@ The result is a manifest list at the tag specified in `-t`, referencing images f
 
 #### Target Platforms
 
-Per default `konet` creates images for all platforms .NET supports and for which there is an official base image available. Those include `windows/amd64:1809, windows/amd64:1903, windows/amd64:1909, windows/amd64:2004, windows/amd64:20H2, windows/amd64:ltsc2022, linux/amd64, linux/arm/v7, linux/arm64/v8`.
+Per default `konet` creates images for all platforms .NET supports and for which there is an official base image available. Those include `linux/amd64,linux/arm/v7,linux/arm64/v8,windows/amd64:1809,windows/amd64:1903,windows/amd64:1909,windows/amd64:2004,windows/amd64:20H2,windows/amd64:ltsc2022`.
 
 You can limit the platforms by adding `-p windows/amd64:ltsc2022,linux/amd64` to `konet build`.
 

diff --git a/konet.csproj b/konet.csproj
@@ -9,7 +9,7 @@
     <ToolCommandName>konet</ToolCommandName>
     <PackageOutputPath>./nupkg</PackageOutputPath>
     <PackageId>konet</PackageId>
-    <Version>0.0.4</Version>
+    <Version>0.0.5</Version>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageIcon>images/logo.png</PackageIcon>
     <PackageReadmeFile>docs/README.md</PackageReadmeFile>