feat: Add MountPoint option to AdditionalVolumes #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
force-pushed
the
module-mounts
branch
from
60455eb to
f2e4ed6
Compare
13 tasks
Callisto13
force-pushed
the
module-mounts
branch
2 times, most recently
from
5f06488 to
0409290
Compare
Callisto13
changed the title
|
Validated cluster can start with this config: rootVolume:
id: root
image: "docker.io/claudiaberesford/capmvm-k8s-os:1.23.5"
kernel:
filename: "boot/vmlinux"
image: "docker.io/claudiaberesford/kernel-bin:5.10.77"
volumes:
- id: modules
image: "docker.io/claudiaberesford/kernel-modules:5.10.77"
mountPoint: /lib/modules/5.10.77 |
yitsushi
previously approved these changes
Jan 12, 2023
Callisto13
force-pushed
the
module-mounts
branch
from
0409290 to
a676deb
Compare
|
sorry @yitsushi i saw a mistake :p |
Callisto13
force-pushed
the
module-mounts
branch
from
a676deb to
5ba7cef
Compare
yitsushi
previously approved these changes
Jan 12, 2023
And update templates to use a dedicated binary image for `kernel.image` and an additional volume to provide the modules. In line with changes to our image-builder pipeline, which removes the embedded kernel modules from the OS image, this feature adds an option to include modules as an additional volume. Old images will remain available to not break those using earlier versions.
Callisto13
force-pushed
the
module-mounts
branch
from
5ba7cef to
a6d5124
Compare
yitsushi
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update templates to use a dedicated binary image for
kernel.imageand an additional volume to provide the modules.
In line with changes to our image-builder pipeline, which removes the
embedded kernel modules from the OS image, this feature adds an option
to include modules as an additional volume.
Old images will remain available to not break those using
earlier versions.
Part of liquidmetal-dev/image-builder#49