Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not default mount point for volumes #61

Merged
merged 1 commit into from
Dec 14, 2021
Merged

fix: do not default mount point for volumes #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ type Volume struct {
// ID is a unique identifier for this volume.
// +kubebuilder:validation:Required
ID string `json:"id"`

// Image is the container image to use for the volume.
// +kubebuilder:validation:Required
Image string `json:"image"`
// ReadOnly specifies that the volume is to be mounted readonly.
// +kubebuilder:default:=false
// +optional
ReadOnly bool `json:"readOnly,omitempty"`
// MountPoint is the mount point of the volume in the machine.
// +kubebuilder:default:=/
// +kubebuilder:validation:Required
MountPoint string `json:"mountPoint,omitempty"`
}

Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_microvmmachines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@ spec:
description: Image is the container image to use for the volume.
type: string
mountPoint:
default: /
description: MountPoint is the mount point of the volume in the
machine.
type: string
readOnly:
default: false
description: ReadOnly specifies that the volume is to be mounted
readonly.
type: boolean
Expand All @@ -157,11 +157,11 @@ spec:
description: Image is the container image to use for the volume.
type: string
mountPoint:
default: /
description: MountPoint is the mount point of the volume in
the machine.
type: string
readOnly:
default: false
description: ReadOnly specifies that the volume is to be mounted
readonly.
type: boolean
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_microvmmachinetemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@ spec:
volume.
type: string
mountPoint:
default: /
description: MountPoint is the mount point of the volume
in the machine.
type: string
readOnly:
default: false
description: ReadOnly specifies that the volume is to
be mounted readonly.
type: boolean
Expand Down Expand Up @@ -197,11 +197,11 @@ spec:
the volume.
type: string
mountPoint:
default: /
description: MountPoint is the mount point of the volume
in the machine.
type: string
readOnly:
default: false
description: ReadOnly specifies that the volume is to
be mounted readonly.
type: boolean
Expand Down