refactor: microvmmachine controllers individual tests #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the MicrovmMachine controller tests away from the single test with subtests to individual tests. This is mainly to help with the debug / run single test dev experience. Without this change it would require commenting out all the subtests you are no interested in....a pain in the rear end. Signed-off-by: Richard Case <[email protected]>
Unless you use ginkgo or some plugin then it is piece of cake 😉 |
Callisto13
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changed the MicrovmMachine controller tests away from the single test
with subtests to individual tests. This is mainly to help with the debug
/ run single test dev experience. Without this change it would require
commenting out all the subtests you are no interested in....a pain in
the rear end.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #44
Special notes for your reviewer:
Checklist: